clawlter/camofox-firecrawl-shim
Watch
1
0
Fork
You've already forked camofox-firecrawl-shim
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WIP: Report only observed document transport metadata #12

Closed
clawlter wants to merge 1 commit from audit/document-metadata into main
pull from: audit/document-metadata
merge into: clawlter:main
Conversation 2 Commits 1 Files changed 3 +142 -9
clawlter commented 2026-07-11 21:21:25 -04:00
Owner
Copy link

Summary

  • report the browser-observed final URL, response status, and MIME content type when available
  • omit unknown transport metadata and unsupported per-navigation proxy provenance
  • cover redirects, HTTP errors, non-HTML responses, and missing metadata with local fixtures

Verification

  • env -u PYTHONPATH uv run --no-project --offline --with-requirements requirements-dev.txt python -m pytest -q (27 passed)
  • env -u PYTHONPATH uv run --no-project --offline --with-requirements requirements-dev.txt ruff check shim.py tests
  • git diff --check
  • generated browser evaluation expression executed under Node with mocked navigation timing
## Summary - report the browser-observed final URL, response status, and MIME content type when available - omit unknown transport metadata and unsupported per-navigation proxy provenance - cover redirects, HTTP errors, non-HTML responses, and missing metadata with local fixtures ## Verification - `env -u PYTHONPATH uv run --no-project --offline --with-requirements requirements-dev.txt python -m pytest -q` (27 passed) - `env -u PYTHONPATH uv run --no-project --offline --with-requirements requirements-dev.txt ruff check shim.py tests` - `git diff --check` - generated browser evaluation expression executed under Node with mocked navigation timing
fix: report observed document metadata
All checks were successful
CI / Validate formatting, linting, and tests (pull_request) Successful in 1m46s
Details
bfefd1e3c7
clawlter changed title from Report only observed document transport metadata to WIP: Report only observed document transport metadata 2026-07-11 21:21:56 -04:00
clawlter commented 2026-07-11 23:08:51 -04:00
Author
Owner
Copy link

Reviewer verdict: APPROVED

Findings

  • Blocker: none.
  • Important: none.
  • Minor: none.
  • Question: none.

Verification performed

  • pytest -q: 27 passed.
  • ruff check ., ruff format --check ., py_compile, and git diff --check: passed.
  • Exercised the generated page-context expression with deterministic redirect-final, HTTP 503, JSON, document-content-type fallback, absent-metadata, and invalid-status inputs; final make_document normalization retained only integer HTTP status codes 100–599 and non-empty observed content types.
  • Live Camofox health check passed; a temporary tab confirmed the deployed engine reports Firefox 135.0, above Firefox 129 where MDN browser-compat-data records support for PerformanceResourceTiming.responseStatus and .contentType. The temporary tab/session returned to zero after cleanup/idle release.
  • PR head CI is successful; merge-tree reports no conflict with current main; added-line secret-pattern scan found no credential material.

Residual risks

  • The repository tests simulate Camofox result payloads rather than running browser-backed local HTTP redirect/error/non-HTML fixtures. That leaves a low integration-test gap, but the browser support check and direct expression harness support approval.
  • Transport metadata remains best-effort by design: unsupported/zero/empty browser timing values are omitted rather than fabricated.

Exact unblock criteria: none; this review approves the implementation. The PR remains draft and should be marked ready before merge.

Reviewer verdict: APPROVED Findings - Blocker: none. - Important: none. - Minor: none. - Question: none. Verification performed - `pytest -q`: 27 passed. - `ruff check .`, `ruff format --check .`, `py_compile`, and `git diff --check`: passed. - Exercised the generated page-context expression with deterministic redirect-final, HTTP 503, JSON, document-content-type fallback, absent-metadata, and invalid-status inputs; final `make_document` normalization retained only integer HTTP status codes 100–599 and non-empty observed content types. - Live Camofox health check passed; a temporary tab confirmed the deployed engine reports Firefox 135.0, above Firefox 129 where MDN browser-compat-data records support for `PerformanceResourceTiming.responseStatus` and `.contentType`. The temporary tab/session returned to zero after cleanup/idle release. - PR head CI is successful; merge-tree reports no conflict with current `main`; added-line secret-pattern scan found no credential material. Residual risks - The repository tests simulate Camofox result payloads rather than running browser-backed local HTTP redirect/error/non-HTML fixtures. That leaves a low integration-test gap, but the browser support check and direct expression harness support approval. - Transport metadata remains best-effort by design: unsupported/zero/empty browser timing values are omitted rather than fabricated. Exact unblock criteria: none; this review approves the implementation. The PR remains draft and should be marked ready before merge.
clawlter commented 2026-07-14 08:15:26 -04:00
Author
Owner
Copy link

Closing without merge because the owner cancelled the code-security-audit-2026-07 campaign. This does not revert previously merged work.

Closing without merge because the owner cancelled the `code-security-audit-2026-07` campaign. This does not revert previously merged work.
clawlter closed this pull request 2026-07-14 08:15:27 -04:00
All checks were successful
CI / Validate formatting, linting, and tests (pull_request) Successful in 1m46s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
clawlter/camofox-firecrawl-shim!12
No description provided.