WIP: Align health checks with loader contract #25

Closed

clawlter wants to merge 2 commits from audit/health-loader-contract into main

pull from: audit/health-loader-contract

merge into: clawlter:main

clawlter:main

clawlter:wt/t_33b1da60

Conversation 3 Commits 2 Files changed 5 +213 -30

clawlter commented 2026-07-12 03:04:57 -04:00

Owner

Copy link

Summary

• define one SQLite table/column contract shared by the loader and readiness check
• make readiness load the wiki corpus so unreadable or unparsable pages fail closed
• cover valid and loader-incompatible /api/health fixtures with HTTP status regressions

Verification

• npm run lint
• npm run typecheck
• npm test -- --run tests/health.test.ts tests/fact-store.test.ts (8 passed)
• npm test -- --maxWorkers=1 (23 files, 54 tests passed; default parallel execution hit pre-existing UI-test timeouts under worker contention)
• npm run build

Remote CI is expected to run on this draft PR.

## Summary - define one SQLite table/column contract shared by the loader and readiness check - make readiness load the wiki corpus so unreadable or unparsable pages fail closed - cover valid and loader-incompatible `/api/health` fixtures with HTTP status regressions ## Verification - `npm run lint` - `npm run typecheck` - `npm test -- --run tests/health.test.ts tests/fact-store.test.ts` (8 passed) - `npm test -- --maxWorkers=1` (23 files, 54 tests passed; default parallel execution hit pre-existing UI-test timeouts under worker contention) - `npm run build` Remote CI is expected to run on this draft PR.

clawlter added 1 commit 2026-07-12 03:04:57 -04:00

fix(health): validate loader backend contract e96e91c950

clawlter changed title from Draft: Align health checks with loader contract to WIP: Align health checks with loader contract 2026-07-12 03:06:43 -04:00

clawlter added 1 commit 2026-07-12 04:46:13 -04:00

fix(health): validate runtime loader data 661575af14

clawlter force-pushed audit/health-loader-contract from 661575af14 to 596eda2b81 2026-07-12 10:18:59 -04:00 Compare

clawlter commented 2026-07-12 10:20:02 -04:00

Author

Owner

Copy link

Integration staging update (unmerged): reviewed head 661575af14ce9d58fd4d6e2690b91b3d43b67cde → staged head 596eda2b8158ad77fce0dd4249e60d7f08789e63. Rebased signed commits onto main 383b526 with one narrow test-only reconciliation: the health fixture retains main’s copy-once SQLite template optimization while expanding that template to the reviewed full loader schema/data checks. Product code is unchanged by the reconciliation. Local npm ci, lint, typecheck, full Vitest, and production build all pass. Required exact-head Forgejo checks are running; this changed head remains for fresh independent review.

Integration staging update (unmerged): reviewed head `661575af14ce9d58fd4d6e2690b91b3d43b67cde` → staged head `596eda2b8158ad77fce0dd4249e60d7f08789e63`. Rebased signed commits onto main 383b526 with one narrow test-only reconciliation: the health fixture retains main’s copy-once SQLite template optimization while expanding that template to the reviewed full loader schema/data checks. Product code is unchanged by the reconciliation. Local `npm ci`, lint, typecheck, full Vitest, and production build all pass. Required exact-head Forgejo checks are running; this changed head remains for fresh independent review.

clawlter commented 2026-07-12 11:27:29 -04:00

Author

Owner

Copy link

Exact-head staging checks are green for 596eda2b8158ad77fce0dd4249e60d7f08789e63: both protected pull-request contexts succeeded. Current main is an ancestor and every staged post-main commit has a good signature. This PR remains unmerged and awaits independent staged-head review.

Exact-head staging checks are green for `596eda2b8158ad77fce0dd4249e60d7f08789e63`: both protected pull-request contexts succeeded. Current main is an ancestor and every staged post-main commit has a good signature. This PR remains unmerged and awaits independent staged-head review.

clawlter commented 2026-07-14 08:15:59 -04:00

Author

Owner

Copy link

Closing without merge because the owner cancelled the code-security-audit-2026-07 campaign. This does not revert previously merged work.

Closing without merge because the owner cancelled the `code-security-audit-2026-07` campaign. This does not revert previously merged work.

clawlter closed this pull request 2026-07-14 08:16:00 -04:00

All checks were successful

Hide checks

Build and publish container image / Build Docker image and publish package tags (pull_request) Successful in 5m57s

Required

Details

CI / Validate lint, types, tests, and production build (pull_request) Successful in 3m35s

Required

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

clawlter/hermes-brain-web!25

No description provided.