clawlter/hermes-usage-insights
Watch
1
0
Fork
You've already forked hermes-usage-insights
 0
Code Issues Pull requests Projects Releases 3 Packages 1 Wiki Activity Actions

Make Hermes collector writes atomic and monotonic #26

Merged
clawlter merged 1 commit from audit/collector-atomicity into main 2026-07-11 19:06:14 -04:00
Conversation 1 Commits 1 Files changed 3 +162 -3
clawlter commented 2026-07-11 18:40:22 -04:00
Owner
Copy link

Remediates HUI-001 and HUI-002.

Baseline: 36a6494b01538328d906dfc8b3d9393ec0690a33
Head: abf71f5100c9cf1c04c5cbdd66a4160c73fe172f

Behavior

  • Wraps each Hermes snapshot import in one BEGIN IMMEDIATE transaction so checkpoint and event writes commit or roll back together.
  • Serializes overlapping collectors before checkpoint reads.
  • Merges cumulative counters monotonically so a stale snapshot cannot lower the checkpoint or create duplicate deltas.

Regression evidence

  • Injected event-insert failure leaves no checkpoint; retry imports the complete synthetic total.
  • Two independent SQLite connections importing overlapping newer/older synthetic totals finish with one exact total and the newer checkpoint.
  • Regressions failed on the audited baseline and pass on this head.

Verification

  • uv run pytest -q (16 passed)
  • uv run black --check src tests
  • uv run isort --check-only src tests
  • uv run pyright
  • uv run python -m build and uv run twine check dist/*
  • uv run mkdocs build --strict
  • Synthetic CLI import twice: imported 1, then 0; summary remained 20 tokens.

Residual risk

SQLite uses its configured busy timeout. A writer held longer than that can cause a collector run to fail safely rather than wait indefinitely; a later retry remains lossless. Cumulative counters are intentionally treated as monotonic for a stable Hermes session ID.

Remediates HUI-001 and HUI-002. Baseline: `36a6494b01538328d906dfc8b3d9393ec0690a33` Head: `abf71f5100c9cf1c04c5cbdd66a4160c73fe172f` ## Behavior - Wraps each Hermes snapshot import in one `BEGIN IMMEDIATE` transaction so checkpoint and event writes commit or roll back together. - Serializes overlapping collectors before checkpoint reads. - Merges cumulative counters monotonically so a stale snapshot cannot lower the checkpoint or create duplicate deltas. ## Regression evidence - Injected event-insert failure leaves no checkpoint; retry imports the complete synthetic total. - Two independent SQLite connections importing overlapping newer/older synthetic totals finish with one exact total and the newer checkpoint. - Regressions failed on the audited baseline and pass on this head. ## Verification - `uv run pytest -q` (16 passed) - `uv run black --check src tests` - `uv run isort --check-only src tests` - `uv run pyright` - `uv run python -m build` and `uv run twine check dist/*` - `uv run mkdocs build --strict` - Synthetic CLI import twice: imported 1, then 0; summary remained 20 tokens. ## Residual risk SQLite uses its configured busy timeout. A writer held longer than that can cause a collector run to fail safely rather than wait indefinitely; a later retry remains lossless. Cumulative counters are intentionally treated as monotonic for a stable Hermes session ID.
fix: make Hermes collection atomic
All checks were successful
Python CI / Build source and wheel distributions (pull_request) Successful in 7m51s
Details
Python CI / Validate formatting, typing, and tests (pull_request) Successful in 1m51s
Details
Python CI / Validate formatting, typing, and tests (push) Successful in 6m31s
Details
Python CI / Build source and wheel distributions (push) Successful in 5m40s
Details
abf71f5100
clawlter commented 2026-07-11 19:06:07 -04:00
Author
Owner
Copy link

Independent reviewer verdict: APPROVED at exact head abf71f5100. Verified signed logical commit; baseline/main ancestry and three-file diff scope; atomic rollback and lossless retry; serialized two-connection import with monotonic checkpoint; normal idempotency; SQLite-compatible additive/no-migration changes; 2 focused and 16 full tests; Black, isort, Pyright, package build, Twine, strict MkDocs, synthetic CLI smoke; redaction-safe added-line secret scan; and both exact-SHA Forgejo CI contexts successful. No blocker/important/minor findings. Residual: long writers can exceed SQLite busy timeout and fail safely for later retry; stable session counters are assumed cumulative. Forgejo rejected a formal approval because the shared clawlter service identity authored the PR, so this comment records the independent reviewer-profile gate.

Independent reviewer verdict: APPROVED at exact head abf71f5100c9cf1c04c5cbdd66a4160c73fe172f. Verified signed logical commit; baseline/main ancestry and three-file diff scope; atomic rollback and lossless retry; serialized two-connection import with monotonic checkpoint; normal idempotency; SQLite-compatible additive/no-migration changes; 2 focused and 16 full tests; Black, isort, Pyright, package build, Twine, strict MkDocs, synthetic CLI smoke; redaction-safe added-line secret scan; and both exact-SHA Forgejo CI contexts successful. No blocker/important/minor findings. Residual: long writers can exceed SQLite busy timeout and fail safely for later retry; stable session counters are assumed cumulative. Forgejo rejected a formal approval because the shared clawlter service identity authored the PR, so this comment records the independent reviewer-profile gate.
clawlter changed title from WIP: Make Hermes collector writes atomic and monotonic to Make Hermes collector writes atomic and monotonic 2026-07-11 19:06:07 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
clawlter/hermes-usage-insights!26
No description provided.